20 May
2021
20 May
'21
10:38 p.m.
Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54033 )
Change subject: mstarddc_spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 2:
(1 comment)
File mstarddc_spi.c:
https://review.coreboot.org/c/flashrom/+/54033/comment/345cb3b3_fb9ae5e2 PS1, Line 236: goto out;
I have fixed exactly that... […]
(marking as resolved to indicate this is ready for review)
--
To view, visit https://review.coreboot.org/c/flashrom/+/54033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0e5f6879bfbfac591a40119ee3e0942a5cbc4b9
Gerrit-Change-Number: 54033
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 21 May 2021 05:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment