Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par_master ......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
I found more issues. […]
I'll bring back the mappers for the SPI masters. IMO, if I have to bring back the infrastructure, I would rather preserve behavior for all of the other masters I'm unable to test, so I'll probably restore ICH7 and ICH9 swseq as well if it works out cleanly. I definitely don't want to go refactoring lots of programmers in this patch ;-)
So I can shoehorn a way for SPI masters to set the mapper in par_master, or move the mappers back up to registered_master, or possibly add a mapper to spi_master. I'm leaning toward spi_master I think if I can get it handled cleanly.
I don't think we need mappers for any of the opaque masters. (linux_mtd and nicintel_eeprom already used fallback, I tested ichspi.)
Have a good vacation, I'll probably leave more updates and comments here as I go but no rush!
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/1a4d1525_61d19f6a PS5, Line 919: 1024
we have a `KiB` macro
Ack