Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@244 PS1, Line 244: 7 This should be correct. But please check this value again. My documentation says something else. It might be a typo in the docs.
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: ME On APL this is not the place for the ME/TXE image. Only for the TXE ROM Bypass in pre production
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: TXE This is only the TXE ROM Bypass for pre production not the whole TXE