Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68249 )
Change subject: flashrom.c: Use programmer_init() func params over global ......................................................................
flashrom.c: Use programmer_init() func params over global
The 'programmer' intended to be used in the control flow of 'programmer_init()' is a parameter to the function. Therefore use that symbol directly over the global copy of it.
Change-Id: I71e61f0633bac2fc472971249910bf3bf57cd0eb Signed-off-by: Edward O'Callaghan quasisec@google.com --- M flashrom.c 1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/68249/1
diff --git a/flashrom.c b/flashrom.c index e0fcf6e..7996e6b 100644 --- a/flashrom.c +++ b/flashrom.c @@ -161,8 +161,8 @@ cfg.params = NULL; }
- msg_pdbg("Initializing %s programmer\n", programmer->name); - ret = programmer->init(&cfg); + msg_pdbg("Initializing %s programmer\n", prog->name); + ret = prog->init(&cfg); if (cfg.params && strlen(cfg.params)) { if (ret != 0) { /* It is quite possible that any unhandled programmer parameter would have been valid,