Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41125 )
Change subject: realtek_mst_i2c_spi.c: Fix wp gpio toggle ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41125/2/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/41125/2/realtek_mst_i2c_spi.c@167 PS2, Line 167: /* Set pin value to high, 0xFFD7[0] = 1. */ Update the comment.
https://review.coreboot.org/c/flashrom/+/41125/2/realtek_mst_i2c_spi.c@337 PS2, Line 337: ret = realtek_mst_i2c_spi_toggle_protection(fd, 0); This seems like a strange place to do this considering this write protect should control whether the flash chip's write protect can be disabled.