Attention is currently required from: Anton Samsonov, Anton Samsonov, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email )
Change subject: Remove dependency on C23 __has_include()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
add testing info in commit message. […]
Looks good! And you already wrote it, just copy paste into commit message.
There is no "golden example" of how testing info should look like - it depends on the patch, the main idea is to give this info just in case. Why I am asking in this patch: it touches different environments, and knowing which environment you tested, might be useful.
No strict rules, the paragraph you wrote looks good. Thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6
Gerrit-Change-Number: 77089
Gerrit-PatchSet: 4
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Anton Samsonov
avscomputing@gmail.com
Gerrit-CC: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Attention: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-Comment-Date: Wed, 22 Nov 2023 11:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-MessageType: comment