Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69402 )
Change subject: flashrom_tester: Check the WP state when setting
......................................................................
Patch Set 5:
(2 comments)
File util/flashrom_tester/src/tester.rs:
https://review.coreboot.org/c/flashrom/+/69402/comment/ffb54d18_2ae36eec
PS4, Line 238: let actual_state = Self::get_sw(self.cmd).map_err(|e| e.to_string())?;
Aha I have discovered a bug with this. […]
Done
https://review.coreboot.org/c/flashrom/+/69402/comment/f575a8ac_c1a22208
PS4, Line 240: Err(format!("set_sw request={}, real={}", enable, actual_state))
This error could be more descriptive. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie7f90ab478dca6f92eaa0908443e3cb156ea0319
Gerrit-Change-Number: 69402
Gerrit-PatchSet: 5
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 04:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment