Attention is currently required from: Paul Menzel, Daniel Campello.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62794 )
Change subject: flashrom.8.tmpl: Clarify man entries for -r/-w/-x
......................................................................
Patch Set 2:
(2 comments)
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62794/comment/2769c93d_e23be084
PS2, Line 80: .B "-r, --read <file|->"
Is this implemented?
https://review.coreboot.org/c/flashrom/+/62794/comment/a6aeef9c_4b9c1e51
PS2, Line 80: |-
Technically, what we put in <> is a placeholder. But the - is meant
literally. So I guess what we'd want is
(<file>|-)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f
Gerrit-Change-Number: 62794
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Tue, 15 Mar 2022 21:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment