Attention is currently required from: Angel Pons, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52883 )
Change subject: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52883/comment/3de7fd02_ca418c9e PS2, Line 6274: GD25B128B The 25B versions don't support QPI (only regular Quad-SPI wich uses a single wire for the command). The 25Q128B and C versions were probably added separately because of minor differences (OTP sizes and SFDP support?).
If we wanted separate entries it should be one for 25B128B (or actually 25B128C, as that's what the commit message that added it suggested) and one for the 25Q versions.
I would not mind joining them into one entry _without_ FEATURE_QPI. But this would probably be a short-term solution, I have my first programmer supporting quad modes on my table.