11 Apr
2022
11 Apr
'22
9:07 p.m.
Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63489 )
Change subject: tests: Fix -Wmissing-prototypes warnings ......................................................................
Patch Set 1:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/63489/comment/2e6d78f5_388192e4 PS1, Line 50: static
It's part of fixing the warnings, though.
The scope is set by the commit message. So currently Angel seems right, but splitting the commit would also make it easier to have a good commit message that explains what changes and not how the change was triggered :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/63489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ff22deb2354569f277649c6575ef2d5ffbb6e0
Gerrit-Change-Number: 63489
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 11 Apr 2022 11:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment