Attention is currently required from: David Hendricks, Edward O'Callaghan.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 )
Change subject: layout: Add -i <region>[:<file>] support
......................................................................
Patch Set 17:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/23021/comment/eabd772d_63492a64
PS16, Line 1337: %s
This can just be changed to "the expected size" for all cases to avoid the extra complicated interfa […]
Done
https://review.coreboot.org/c/flashrom/+/23021/comment/e5ab76db_f943089f
PS16, Line 2720: get_num_include_args_with_files(get_layout(flash)) > 0
This is not needed. […]
Done
File layout.c:
https://review.coreboot.org/c/flashrom/+/23021/comment/d73dbed2_ddc967fc
PS16, Line 293: layout->entries[i].included = true;
I think this was removed by mistake.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/23021
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 17
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 13 Apr 2021 02:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Campello
campello@chromium.org
Gerrit-MessageType: comment