Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38488 )
Change subject: Automatic programmer driver writer
......................................................................
Patch Set 2:
(2 comments)
Thanks for the comments.
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh
File build_new_driver.sh:
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@1
PS1, Line 1: #!/bin/bash
'/usr/bin/env bash' is preferred.
Will be fixed in the next iteration.
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@42
PS1, Line 42:
What are your thoughts on putting the lines below in a separate file (build_new_driver.sh. […]
Done.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38488
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd000001
Gerrit-Change-Number: 38488
Gerrit-PatchSet: 2
Gerrit-Owner: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 01 Feb 2020 19:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment