David Hendricks has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/#/c/23203/15/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/#/c/23203/15/cli_classic.c@247
PS15, Line 247: cli_classic_abort_usage();
So again (as said in patchset 10 already): […]
You are correct, it was I who missed something. I've added the additional checks in PS16. The newly introduced fmap integer will also be used for OPTION_FMAP in the next patch.
--
To view, visit
https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 20 Jul 2018 23:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No