Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38209 )
Change subject: raiden_debug: Upstream ChromiumOS servo debug board prog
......................................................................
Patch Set 7:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/38209/comment/ae2bf0bc_49007891
PS7, Line 229: ifeq ($(CONFIG_RAIDEN), yes)
: UNSUPPORTED_FEATURES += CONFIG_RAIDEN=yes
: else
: override CONFIG_RAIDEN = no
: endif
What's the reasoning here? Does it need more than libusb?
File meson.build:
https://review.coreboot.org/c/flashrom/+/38209/comment/602752d0_fb165318
PS7, Line 109: config_raiden = false
Huh, this dependency is not mentioned in the Makefile...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifad273a708acea4de797a0808be58960635a8864
Gerrit-Change-Number: 38209
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 29 Mar 2021 19:04:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment