Andy Pont has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48643 )
Change subject: chipset_enable.c: Remove futile attempt to disable lock ......................................................................
chipset_enable.c: Remove futile attempt to disable lock
For all recent Intel chipsets (and possibly others) the ability to disable the lock fails. This leads to confusing messages being presented to the user where unlocking fails but the flash update process works correctly.
Remove the unlock attempt which had alreayd been marked in the source code comments as "futile".
Signed-off-by: Andy Pont andy.pont@sdcsystems.com Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b --- M chipset_enable.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48643/1
diff --git a/chipset_enable.c b/chipset_enable.c index 9205d0e..3ca6ba8 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -333,7 +333,6 @@ wanted |= (1 << 2);
wanted |= (1 << 0); /* Set BIOS Write Enable */ - wanted &= ~(1 << 1); /* Disable lock (futile) */
/* Only write the register if it's necessary */ if (wanted != old) {