Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35793 )
Change subject: cli_classic: Fix first line of --help to match manpage
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/35793/3/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35793/3/cli_classic.c@40
PS3, Line 40: "\t\t[-E|(-r|-w|-v) <file>]\n"
: "\t\t[(-l <layoutfile>|--ifd| --fmap|--fmap-file <file>) [-i <imagename>]...]\n"
: "\t\t[-n] [-N] [-f])]\n"
Nit, these three lines are within the opening parenthesis the line
above. Shouldn't this have an additional tab? or a space maybe, to
align with the (.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I44f82c6a54fddb54bf268fe6eb22e50acb6025cf
Gerrit-Change-Number: 35793
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 10:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment