Attention is currently required from: Nico Huber, Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59280 )
Change subject: pcidev: Move pci_dev_find() from internal to canonical place ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59280/comment/b0438a56_ac69b313 PS5, Line 10: sudo ./flashrom -p internal -r /tmp/bios
The same comment as in the previous patch: if you could add info what environment the command was pe […]
As previously, it was run across a great number of DUT's. Code emission is identical as the symbol is simply moved. No functional changes occured.
Patchset:
PS5:
Same as previous patch, this is also done by CB:55848. Reorder the prototypes in programmer. […]
Well the rename was separated out as I suspected someone would want it separate, I would actually prefer it to be squashed in.
The collection of function signatures being its own patch sounds excessive, notice the comment on line 253 that would leave intermediate steps with erroneous/misleading header guards and comments. Hence to keep changes atomic and logically consistent.