Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Patrick Rudolph.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user
......................................................................
Patch Set 15: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/8c8cd7a9_ee190305
PS11, Line 15:
Done. […]
Dummyflasher is useful for sure, thanks! I would still want to test on a real device. If you don't have capacity, let me know, me or Peter can test the patch. linux_mtd should not be a problem.
I am leaving this unresolved for testing, and meanwhile other people can have a look.
Otherwise I have no other comments on the code.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Gerrit-Change-Number: 49643
Gerrit-PatchSet: 15
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Richard Hughes
hughsient@gmail.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 12 May 2022 00:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Daniel Campello
campello@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment