Attention is currently required from: DZ, Hsuan Ting Chen, Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81792?usp=email )
Change subject: flashchips: Split and add write-protect support for MX25L12833F
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81792/comment/9503ca9a_49a1434f :
PS5, Line 9038: /* TODO: security register and SBLK/SBULK; */
I am not sure what is SBLK/SBULK but I think this TODO can be removed.
https://review.coreboot.org/c/flashrom/+/81792/comment/7c5c22e9_6db225a1 :
PS5, Line 9086: /* TODO: security register and SBLK/SBULK; MX25L12835F: configuration register */
Same: this TODO can be removed
https://review.coreboot.org/c/flashrom/+/81792/comment/0de248eb_38192063 :
PS5, Line 9134: /* TODO: security register and SBLK/SBULK */
Same: this TODO can be removed
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81792?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc
Gerrit-Change-Number: 81792
Gerrit-PatchSet: 5
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 10:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment