Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45230 )
Change subject: dummyflasher.c: Factor out global state ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c@407 PS3, Line 407: sg_perr("Out of memory!\n"); : return 1; this could later be cleaned up with a goto on the error paths but free(data) here
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c@459 PS3, Line 459: free(flashchip_contents); : return 1; free(data) here