Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Anastasia Klimchuk.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )
Change subject: pony_spi.c: Fix memory leak in function pony_init_spi
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/c33d0444_58349124
PS3, Line 11: ii
This seems to be still in the latest patchset? Still 2 ii in "deallocatiing".
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/04f34a5e_3a01460b
PS7, Line 9: Memory leaked was caused
I think "Memory leak was caused" sounds better (memory leak instead of memory leaked).
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 8
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 14 Mar 2022 09:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Light
aarya.chaumal@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment