Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36433 )
Change subject: sb600spi.c: Don't access spibar directly ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/flashrom/+/36433/1/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36433/1/sb600spi.c@45 PS1, Line 45: usually no space after the asterisk
https://review.coreboot.org/c/flashrom/+/36433/1/sb600spi.c@597 PS1, Line 597: /* Physical memory has to be mapped at page (4k) boundaries. */ huh?
(looks like our rphysmap() implementation is buggy)