22 Mar
2022
22 Mar
'22
8:29 a.m.
Attention is currently required from: Edward O'Callaghan, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59283 )
Change subject: dmi.c: Hide has_dmi_support global behind method ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File dmi.c:
https://review.coreboot.org/c/flashrom/+/59283/comment/a84aec94_b84bd32e PS3, Line 388: }
I am inclined to put `g_has_dmi_support = false;` here but not sure if it should be a separate patch […]
A separate patch is better.
--
To view, visit https://review.coreboot.org/c/flashrom/+/59283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibded9714998ea6f2e5d4e0512fa7c6b105f9638a
Gerrit-Change-Number: 59283
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 22 Mar 2022 08:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment