Attention is currently required from: Alan Green, Samir Ibradžić.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55695 )
Change subject: ft2232_spi: Revise comments about output pin states
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Alan, Samir, I'm sorry about the reverts. I think it's best to
restart from a sound code base. If you think it's easier to fix
everything on top of the current TOT, please go ahead and ignore
the reverts.
It seems you were both working on the same feature, general GPIO
control indipendent from CS#. But that's not what the original
`csgpiol` code intended (hence the `cs` in its name).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2b84ede01759c80f69d5ad17e43783d09ecd1107
Gerrit-Change-Number: 55695
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Sun, 20 Jun 2021 14:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment