Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 )
Change subject: Introduce an `include` directory for header files
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File platform/endian_big.c:
https://review.coreboot.org/c/flashrom/+/58622/comment/4851b50e_3dbc00b5
PS4, Line 18: #include "platform.h"
Then this should be done for all includes. […]
Definition no, but sometimes it matters. #include "" looks in the local
directory of the compilation unit first, then in include paths. So for
"../platform.h" the quote form was needed.
Using <> when "" would work too, is probably a personal preference. Why
let the compiler look in the local dir when we know it won't find anything?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 25 Apr 2022 12:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment