Attention is currently required from: Douglas Anderson, David Hendricks, Edward O'Callaghan.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50155 )
Change subject: linux_mtd: Disable buffering on the mtd device
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'm surprised why we didn't see issues until now.
In the meantime, will it make more sense if we change fopen to open for MTD device files?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/50155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6
Gerrit-Change-Number: 50155
Gerrit-PatchSet: 2
Gerrit-Owner: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Douglas Anderson
dianders@chromium.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sat, 30 Jan 2021 02:11:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment