David Hendricks has posted comments on this change. ( https://review.coreboot.org/25706 )
Change subject: linux_mtd: Initial import
......................................................................
Patch Set 3: Verified+1
(2 comments)
https://review.coreboot.org/#/c/25706/2/linux_mtd.c
File linux_mtd.c:
https://review.coreboot.org/#/c/25706/2/linux_mtd.c@15
PS2, Line 15:
: #include <ctype.h>
: #include <errno.h>
This should go away as per https://review.coreboot.org/#/c/flashrom/+/25381/ .
Done
https://review.coreboot.org/#/c/25706/2/linux_mtd.c@383
PS2, Line 383:
This could be made more helpful.
Removed; Specific error messages should be printed where the error occurs.
--
To view, visit
https://review.coreboot.org/25706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599
Gerrit-Change-Number: 25706
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 May 2018 21:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes