Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/19993 )
Change subject: helpers: Add swap_byte() and swap_bytes()
......................................................................
Patch Set 1:
Looks relatively good, but I looked at the ch341a use of swap_byte(), and your use of swap_bytes in the j-link patch, so...
I think we could instead use a swapping_memcpy() (someone, suggest a better name?) that copies the bytes from buffer to buffer while swapping them and adapt both to use that.
--
To view, visit
https://review.coreboot.org/19993
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2e1e2856c835d22eed3b3a34bc0379773dd831
Gerrit-Change-Number: 19993
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Schink
flashrom-dev@marcschink.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Urja Rannikko
urjaman@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Jun 2017 11:50:31 +0000
Gerrit-HasComments: No