David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42555 )
Change subject: [RFC] tree: Prepare for reformatting ......................................................................
Patch Set 6: -Code-Review
(2 comments)
https://review.coreboot.org/c/flashrom/+/42555/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/42555/3//COMMIT_MSG@24 PS3, Line 24: flashchips
This one file is so huge it deserves its own commit.
Oops - I accidentally pushed the actual uncrustify changes in PS3. PS5 and newer show the preparation only where I modified some comments.
CB:42556 PS5 has the actual uncrustified flashchips.c. As you mention it's a huge diff on its own (around 3,500 lines), and in fact Gerrit has performance issues when handling and prompted Patrick to file a bug: https://bugs.chromium.org/p/gerrit/issues/detail?id=12993
I split those changes out of this patch, so marking as "resolved" for now. Should I split it out of CB:42556 as well?
https://review.coreboot.org/c/flashrom/+/42555/3/nicintel_spi.c File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/42555/3/nicintel_spi.c@71 PS3, Line 71: #if 0
Do the definitions conflict with anything? If not, maybe just uncomment them?
Uncommenting them doesn't appear to cause any problems, so let's go with that approach. And while we're at it I removed the "Currently unused" comment since we usually don't bother to mention that when translating data sheets into code.