22 Sep
2021
22 Sep
'21
1:39 p.m.
Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 )
Change subject: ft2232_spi: prevent use of reserved pins on some programmers ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57809/comment/9a77a9de_68da7821 PS2, Line 488: rsv_bits Alternatively, could we use `pindir` here? It would be rather implicit, but seems to make sense. The message could be "GPIOL%u is already configured as output for this programmer.\n"
--
To view, visit https://review.coreboot.org/c/flashrom/+/57809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd
Gerrit-Change-Number: 57809
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 22 Sep 2021 13:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment