Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42796 )
Change subject: ft2232_spi.c: align with Chrome OS flashrom
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c@276
PS1, Line 276: channel_count = 2;
Which is the rationale for this change?
https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c@420
PS1, Line 420: DIS_DIV_5;
OK, SGTM. Please give some time for the community to review as well.
I think we ported the few programmers using old libftdi to use the newer version, so we should be safe
--
To view, visit
https://review.coreboot.org/c/flashrom/+/42796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I24c20e9b5d7e661d0180699bbd0d1447f6bf816f
Gerrit-Change-Number: 42796
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 12:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment