28 Apr
2021
28 Apr
'21
3:14 p.m.
Attention is currently required from: Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52685 )
Change subject: ene_lpc.c: Untangle successful vs failed init paths ......................................................................
Patch Set 3:
(2 comments)
File ene_lpc.c:
https://review.coreboot.org/c/flashrom/+/52685/comment/7598d76c_bf1c1ee3 PS1, Line 575: ene_leave_flash_mode
I introduced second label here (same as in mec1308) which does cleanup. […]
Sorry, didn't mean you should do it right now. Doesn't hurt, though.
File ene_lpc.c:
https://review.coreboot.org/c/flashrom/+/52685/comment/e5bdb385_4e95cf0f PS3, Line 582: return 1; It should fall through instead, right?
--
To view, visit https://review.coreboot.org/c/flashrom/+/52685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac295f1353785cd73d7cb2f19e4a8cbb69beb576
Gerrit-Change-Number: 52685
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-CC: Victor Ding victording@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 15:14:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment