Attention is currently required from: Angel Pons, Nikolai Artemiev, foss@volatilesystems.org.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email )
Change subject: flashchips: Add support for XMC XM25QH128A
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Nikolai, may I ask you to check reg_bits in this chip definition? I checked the rest and replaced remaining fn pointers with enums.
Thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69309?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Gerrit-Change-Number: 69309
Gerrit-PatchSet: 3
Gerrit-Owner: foss@volatilesystems.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: foss@volatilesystems.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Fri, 16 Jun 2023 09:18:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment