Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52364
to look at the new patch set (#2).
Change subject: programmer.h,chipset_enable.c: Make penable fn ptr more descript ......................................................................
programmer.h,chipset_enable.c: Make penable fn ptr more descript
The enable_flash callback function pointer embedded within the penable struct is used by the chipset_enable entry-point to dispatch to the correct concrete implementation. The handles have the canonical form `flash_enable_<chipset-name>()` and therefore `doit()` is hard to comprehend while groking code and seeing to what it refers to. It is also a little more confusing as there used to be another doit() in flashrom once upon a time.
BUG=none TEST=builds
Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d Signed-off-by: Edward O'Callaghan quasisec@google.com --- M chipset_enable.c M programmer.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/52364/2