Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev.
Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
Change subject: flashrom: Don't throw around "delay 1 second" so lightly ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/80807/comment/8253b1ea_7abf526e : PS2, Line 13: https://review.coreboot.org/plugins/gitiles/flashrom/+/8ab49e72af8465d4527de...
Oh, gitiles is down at the moment, maybe you can tell the file and line? I would have a look! :)
Ah, I noticed that a day or so after uploading this. That's unfortunate.
It's just a commit link, showing where the progenitor of the lines I'm deleting came from. `git show 8ab49e72af8465d4527de2ec37b22cd44f7a1169` will give you the same info.
The key isn't really the code anyway (it's identical, although it moved around a bit with the addition of libflashrom); it's the commit message, which includes:
``` Wait 1 second between erase and verify. This fixes a few reports where verify directly after erase had unpleasant side effects like corrupting flash or at least getting incorrect verify results. ```