[flashrom-gerrit] Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops

[Michael Niewöhner (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )

Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
......................................................................

Patch Set 19:

(1 comment)

File ite_ecfw.c:

https://review.coreboot.org/c/flashrom/+/55715/comment/144eb421_536b2564 
PS17, Line 835: 
              : 	if (register_shutdown(ite_ecfw_shutdown, ctx_data))
              : 		goto ite_ecfw_init_exit;
              :
> Or do we know any other way of getting out of flashing mode of the EC?

Checked this. Unfortunately not.
> Kind of unlikely to fail registering a shutdown.

Well, with that argument we could justify not checking success at all :-)
> Almost every programmer has this call secured in an IF statement and handles errors. In our case even if we fail to register the shutdown we call it unconditionally in ite_ecfw_init_exit.

... and that's what we shouldn't do IMO. Just `exit 1`, since we're not in flash mode yet.