Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS4:
We could use both DMI and SVID/SDID checks: […]
If we really want to put that much thought into it, we should unify this somehow with `board_enable.c`. For instance, have a common struct and a common function that decides if the host matches. I guess the current rules of `board_enable.c` (when does it match?) are generally debatable, but we should make decisions for the project as a whole and not locally for programmers.
I think forcing in the case of mismatching contents is ok. Or even don't check the contents at all (IMHO the user---not necessarily a human, e.g. fwupd---should be responsible for the data). We should have a look how fwupd does things.
Forcing to run the programmer code on an unknown board would be new to flashrom. I don't see why we would suddenly need that.
If we add forcing options, they should not be global; i.e. never use the classic CLI's `-f` for anything new. Using the same force flag for multiple things turns users blind to it, they'll just always add an `-f` eventually. And then they might force one thing by accident because they wanted to force another.