Attention is currently required from: Felix Singer, Thomas Heijligen.
Alex Badea has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 )
Change subject: asm106x: add programmer for ASM106x SATA controllers ......................................................................
Patch Set 3:
(7 comments)
Patchset:
PS3:
Hi Alex, thank you for the contribution! […]
Ack
File asm106x.c:
https://review.coreboot.org/c/flashrom/+/73037/comment/d300626b_1b94e31e PS3, Line 35: {PCI_VENDOR_ID_ASMEDIA, 0x0612, OK, "ASMedia", "ASM106x"},
This PCI-Id is assigned to the ASM1062 Serial ATA Controller, […]
Well, it's interesting.
From driver blobs[1] linked from forums[2] it looks like this:
$ grep -rh VEN.*DeviceDesc.*" . | sort -u PCI\VEN_1B21&DEV_0601.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0602.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0611.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0612.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0614.DeviceDesc ="Asmedia SATA Express Controller" PCI\VEN_1B21&DEV_0615.DeviceDesc ="Asmedia SATA Express Controller" PCI\VEN_1B21&DEV_0620.DeviceDesc ="Asmedia 106x SATA Controller" PCI\VEN_1B21&DEV_0621.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0622.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0624.DeviceDesc ="Asmedia 106x SATA/RAID Controller" PCI\VEN_1B21&DEV_0625.DeviceDesc ="Asmedia 106x SATA/RAID Controller"
This kernel patch[3] suggests 0x0611 and 0x0612 are both ASM1061.
Either way, I'm not sure if driver compatibility translates into SPI interface compatibility as well. My boards have ASM1061 chips on them and they both report 0x0612, which is what I've declared here. Let me know if I should add the others too (as "NT").
[1] http://ableconn.com/support_1.php?gid=120 [2] https://www.techpowerup.com/forums/threads/latest-driver-and-firmware-for-as... [3] https://patchwork.kernel.org/project/linux-pci/patch/1315453426-8796-1-git-s...
https://review.coreboot.org/c/flashrom/+/73037/comment/7de74237_a053f99b PS3, Line 51: programmer_delay(flash, 10);
`programmer_delay()` should be used outside of the programmer. […]
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/40a74070_b8aac08b PS3, Line 59: if (pval)
You could move this 'if, assignment, return' where the break is. […]
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/f442be14_de7d0d7d PS3, Line 74: writecnt, readcnt);
This can be moved in the line above.
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/fea7da31_c0a735e9 PS3, Line 115: ctrl | ASM106X_CTRL_CSN);
This function call can be in one line
Done
File meson.build:
https://review.coreboot.org/c/flashrom/+/73037/comment/f8b28cb2_e1d6fbbb PS3, Line 152: 'cpu_families' : cpus_port_io,
This line should be removed. […]
Done