Attention is currently required from: Miklós Márton, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54849 )
Change subject: meson/: Add missing config for NI845_SPI drv
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes, NI-845x is only available on Windows. […]
yep meson works on Windows. I have been trying to get this to work with mingw64 locally to make process with somehow get this building in the buildbot to improve build coverage.
Thanks for the feedback Miklós! The dependency() call should theoretically send the toolchain the correct CFLAGS but I would be interested to hear what actually happens on a real Windows box?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I85387e94f1b159733d0124f1a6dfde1e3d16827f
Gerrit-Change-Number: 54849
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 23 May 2021 11:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment