Nico Huber has posted comments on this change. ( https://review.coreboot.org/28910 )
Change subject: flashchips: Add W25Q128J
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28910/1/flashchips.h
File flashchips.h:
https://review.coreboot.org/#/c/28910/1/flashchips.h@928
PS1, Line 928: #define WINBOND_NEX_W25Q128J 0x7018 /* W25Q128J */
As mentioned on IRC, for this id it would have to be "W25Q128.V..M"
maybe WINDBOND_NEX_W25Q128_V_M as the macro name.
--
To view, visit
https://review.coreboot.org/28910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c
Gerrit-Change-Number: 28910
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 04 Oct 2018 13:40:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No