Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ......................................................................
Patch Set 4:
(2 comments)
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/55715/comment/25ecd7a4_763bb9f8 PS4, Line 1376: The default is 1
I don't see the code for this?
`tuxedo_ec_init_ctx` is setting these defaults
File tuxedo_ec.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/d090df84_8fa3de51 PS4, Line 661: dmi_init(); : : if (!dmi_match("^TUXEDO$")) { : msg_perr("Not a TUXEDO device\n"); : return 1; : } : : for (i = 0; i < ARRAY_SIZE(tuxedo_supported_boards); i++) { : if (dmi_match(tuxedo_supported_boards[i])) { : match = true; : break; : } : } : : if (!match) { : msg_perr("TUXEDO EC programmer not yet supported on this device\n"); : return 1; : }
I'd move this into a separate function, and refactor to allow adding support for non-TUXEDO machines […]
I was thinking about the same. Thanks for the piece of code. At this point I should probably consider adding your sign-off to the commit 😊