Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46089 )
Change subject: realtek_mst_i2c_spi.c: Update GPIO pin 88 toggle function
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46089/1/realtek_mst_i2c_spi.c
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/46089/1/realtek_mst_i2c_spi.c@165
PS1, Line 165: 0xF0
Kind of (I have no documentation). […]
Ah yes, sorry for the confusion, I meant to say the last 4 bits actually.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1aed0086f917e31bebb51857ad5cce138158fe82
Gerrit-Change-Number: 46089
Gerrit-PatchSet: 10
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 08:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shiyu Sun
sshiyu@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment