Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82393?usp=email )
Change subject: erasure_layout: Fix get_flash_region bug ......................................................................
Patch Set 14:
(2 comments)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/82393/comment/6598daea_c861aedb?usp... : PS13, Line 368: for (unsigned int addr = region_start; addr <= region_end; addr += len) {
I looked at this loop and got a bit suspicious. […]
I have changed tests, and looked into debugging messages, and now I have a piece of mind that the bug that I suspected is not present :) Happy ending!
However after modifying tests I found something else suspicious: now "Erase protected region test case #3" behaves not as I expect. Specifically, there is a 4byte layout region, outside of protected area. I expect it to be erased by 4byte eraser, instead it is erased by 2b + 2b two erasers. The end state of memory is correct, but the behaviour is not optimal. Maybe that's a double happy ending, if I found a different bug :D
I uploaded the patchset 14 to have a history of changes, but now I will try to debug "Erase protected region test case #3".
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/82393/comment/4df28d74_823d2acc?usp... : PS13, Line 766: : #define START_PROTECTED_REGION 8 : #define END_PROTECTED_REGION 15
This was what I thought in the other comment: have this both in the middle of a chip (5-12, somethin […]
Done (protected region spans bytes 6-13)