Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: "Descr.", "BIOS", "ME", "GbE", "Platf.", "DevExt", "BIOS2", "unknown", Dev*Exp*
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: msg_pdbg2(" FD IFWI TXE n/a Platf DevExt\n"); Dev*Exp*
https://review.coreboot.org/#/c/30995/1/ichspi.c File ichspi.c:
https://review.coreboot.org/#/c/30995/1/ichspi.c@1572 PS1, Line 1572: "Gigabit Ethernet", "Platform Data", "Device Extension", Device *Expansion*