Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54996 )
Change subject: ogp_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File ogp_spi.c:
https://review.coreboot.org/c/flashrom/+/54996/comment/320f5d9f_744f7ff4
PS2, Line 40: ogp_
similar to the others, this `ogp_` prefix can be dropped from the members.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54996
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6b8f6ecd7c9949ffb4098bf56a8936393283382f
Gerrit-Change-Number: 54996
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 31 May 2021 05:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment