Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email )
Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/384af535_3ce7dd8d : PS6, Line 11: https://www.gigadevice.com/datasheet/gd25lr512me/ The links are not working anymore. They probably were working at the moment of patch creation, but not anymore.
I am wondering, Martin maybe you have working links to these datasheets? Then you can replace the links. In any case, the original ones need to be removed.
https://review.coreboot.org/c/flashrom/+/58025/comment/2cb184bc_45bafcb3 : PS6, Line 17: sudo dut-control cold_reset:on fw_wp_en:off spi2_buf_en:on spi2_buf_on_flex_en:on spi2_vref:pp1800 spi_hold:off : sudo flashrom -V -p raiden_debug_spi -w <test_binary> : sudo dut-control spi2_buf_en:off spi2_buf_on_flex_en:off spi2_vref:off spi_hold:off cold_reset:off These are probably the commands used by original patch author (which is all good). Maybe if you tested the chip differently, you could add your commands?
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58025/comment/a166b3ea_e6fa0df6 : PS4, Line 6415: FEATURE_4BA_WREN
I don't think that this chip requires WREN before setting 4 bit addressing. […]
Done
https://review.coreboot.org/c/flashrom/+/58025/comment/3f07fbc5_f1afd65b : PS4, Line 6434: .eraseblocks = { {64 * 1024, 1024} },
It looks like we lost the .block_erase identifier: […]
Done
https://review.coreboot.org/c/flashrom/+/58025/comment/09626ee9_ba71d47a : PS4, Line 6450: .voltage = {1600, 2000},
Maybe add the register bits? I think this is right: […]
Done