Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Kevin Yu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67438 )
Change subject: ichspi: Add Intel Idaville HCC support
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67438/comment/4fa6021d_7b6ebe55
PS4, Line 9: IDs
It's only one ID you are adding
Please also change IDs to ID
https://review.coreboot.org/c/flashrom/+/67438/comment/a6a59fcd_060a71f6
PS4, Line 9: Add Cedar Fork PCH device IDs to enable flashrom on Idaville HCC platforms.
Also, wrap at 72 chars at each line.
Just move the word "platforms" into the next line.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f
Gerrit-Change-Number: 67438
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Yu
ykevin@celestica.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Kevin Yu
ykevin@celestica.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 05:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment