Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Kane Chen.
Hsuan-ting Chen has posted comments on this change by Kane Chen. ( https://review.coreboot.org/c/flashrom/+/83896?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: chipset_enable.c: Use PCI_ACCESS_ECAM to access pci register
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/83896/comment/7921fe4e_de626aec?usp... :
PS6, Line 943: msg_gdbg("Using libpci PCI_ACCESS_ECAM\n");
: #else
: pci_acc->method = PCI_ACCESS_I386_TYPE1;
: msg_gdbg("Using libpci PCI_ACCESS_I386_TYPE1\n");
nit: This file typically uses msg_pdbg(), could we use that for consistency?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83896?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4549f87c8b01da0a1d3d8ce0b3b75c1f5fa2cbab
Gerrit-Change-Number: 83896
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 19 Aug 2024 05:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes