Attention is currently required from: Dmitry Zhadinets.
Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email )
Change subject: libflashrom: Added API to enumerate supported programmers ......................................................................
Patch Set 10:
(5 comments)
Patchset:
PS1:
If you are about iterator. […]
But this is a good idea: `list_programmers_linebreak` iterates through programmers names, which is exactly what this new api returns. What do you mean about iterator? The new api which is introduced in this commit can be used with iterator - the test is doing this already.
Patchset:
PS3:
I had to remove next commits. […]
Yes, I can't open that patch anymore, I understand you removed it.
Although I can see your reply in the email, because the email was sent before the patch was removed :)
I still plan to have a probe v2 (name TBD) and the cli will be its client. v1 will stay forever for anyone who uses it. This is also a stepping stone for more work that I want to do. But now it's all in my head, I will try to make a patch with it. This is not about this commit anyway.
Commit Message:
https://review.coreboot.org/c/flashrom/+/86921/comment/f238b58a_4848a8a2?usp... : PS10, Line 7: libflashrom: Added API to enumerate supported programmers This title we changed earlier as
`libflashrom: Add API to return the list of supported programmers`
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86921/comment/03e73265_96023409?usp... : PS10, Line 199: no space here
File tests/libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86921/comment/9a0e9aa7_0e9a2bdb?usp... : PS10, Line 109: while (*(ptr++)) {} Maybe you can assert inside the loop that programmer name is not empty string (unless it's the last terminating 0)