Attention is currently required from: Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66703 )
Change subject: meson: Overhaul the print_wiki option
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66703/comment/383dfb04_17df8031
PS4, Line 8:
: Rename `print_wiki` to `classic_cli_print_wiki`, make it a feature type
: which depend on classic_cli be not disabled and disable it by default.
So ok?
yes, but I found one new typo in commit message :)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66703/comment/d87b287f_12c80b74
PS5, Line 11: musst
Typo: musst -> must
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic6c959b8b64ec2756b4535bd1b3320860f836aa5
Gerrit-Change-Number: 66703
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 05 Sep 2022 03:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment
